Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2211: Onboarding - Status Bar #641

Merged
merged 10 commits into from Dec 7, 2020
Merged

GH-2211: Onboarding - Status Bar #641

merged 10 commits into from Dec 7, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Dec 7, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Create StepProgressBar component for ghostery-browser-intro-hub
  • Routes should be changed inside the steps object of the StepProgressBar.jsx component
  • A container div should be used to specify the width since the component is flexible
  • Dotted lines sometimes get cut off depending on width, workaround can be to specify a container width, but left flexible for now
  • Dotted line solution from: https://stackoverflow.com/a/53408182
  • Example Usage: <StepProgressBar currentStep="2" />

Ticket: https://ghostery.atlassian.net/browse/GH-2211

@benstrumeyer benstrumeyer requested a review from wlycdgr Dec 7, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Dec 7, 2020
@benstrumeyer benstrumeyer self-assigned this Dec 7, 2020
@wlycdgr
wlycdgr approved these changes Dec 7, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM for merging into intermediate branch purposes

@wlycdgr wlycdgr merged commit edc434e into ghostery-browser-intro-hub Dec 7, 2020
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the GH-2211 branch Jan 29, 2021
@christophertino christophertino added this to the 8.5.5 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants