Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2229: Ensure that BROWSER_INFO_READY before using BROWSER_INFO #642

Merged
merged 1 commit into from Dec 9, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Dec 8, 2020

Ensure that BROWSER_INFO_READY has resolved before using BROWSER_INFO in Metrics#_buildMetricsURL. The check in Metrics#_getProductID is currently redundant but should make it easier to avoid introducing a regression if we later call this method from somewhere other than _buildMetricsURL

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
…R_INFO values in Metrics
@christophertino christophertino added this to the 8.5.5 milestone Dec 9, 2020
@christophertino christophertino merged commit 2790b4d into develop Dec 9, 2020
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GH-2229/fix branch Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants