Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2209: Onboarding - Step 2 - Choose Privacy & Ad Block Settings #643

Merged
merged 1 commit into from Dec 10, 2020
Merged

GH-2209: Onboarding - Step 2 - Choose Privacy & Ad Block Settings #643

merged 1 commit into from Dec 10, 2020

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Dec 9, 2020

  • Updates the BlockSettingsView component with Zeplin designs and Redux actions for changing user settings
  • Adds localization messages for component view
  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@leuryr
Update BlockSettingsView and localization messages
Loading status checks…
044b482
@leuryr leuryr requested a review from ghostery/extension as a code owner Dec 9, 2020
@leuryr leuryr changed the title Update BlockSettingsView and localization messages GH-2209: Onboarding - Step 2 - Choose Privacy & Ad Block Settings Dec 9, 2020
@wlycdgr
wlycdgr approved these changes Dec 10, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Looks good for merging into intermediate branch purposes!
@wlycdgr wlycdgr merged commit cf1ceaa into ghostery-browser-intro-hub Dec 10, 2020
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@christophertino christophertino added this to the 8.5.5 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@leuryr @wlycdgr @christophertino