Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIS-866: Search Communication #647

Merged
merged 17 commits into from Jan 7, 2021
Merged

GIS-866: Search Communication #647

merged 17 commits into from Jan 7, 2021

Conversation

@fcjr
Copy link
Member

@fcjr fcjr commented Dec 22, 2020 •
edited

Exposes the refreshToken for use in the ghostery search extension
@fcjr
add search messager class and allow calling of refreshToken
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
653632e
@fcjr fcjr changed the title add search messager class and allow calling of refreshToken GIS-866: Search Communication Dec 22, 2020
fcjr added 2 commits Dec 22, 2020
@fcjr
only init on gb
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
0985b0f
@fcjr
lint fixes
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
0e51222
@wlycdgr
wlycdgr reviewed Dec 23, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM, just the one JSDoc thing would be great
src/classes/SearchMessager.js Show resolved Hide resolved
@fcjr
add since
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
952a9f4
@wlycdgr
wlycdgr approved these changes Dec 23, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM
@christophertino
christophertino requested changes Dec 24, 2020
View changes
src/background.js Outdated Show resolved Hide resolved
@fcjr
ensure browser info is populated
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
b225f58
@christophertino
christophertino requested changes Jan 4, 2021
View changes
src/background.js Outdated Show resolved Hide resolved
src/background.js Outdated Show resolved Hide resolved
@fcjr
remove gb IS const
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
3e28136
@fcjr fcjr requested a review from jsignanini Jan 4, 2021
@jsignanini
jsignanini reviewed Jan 4, 2021
View changes
src/utils/api.js Show resolved Hide resolved
@jsignanini
jsignanini requested changes Jan 4, 2021
View changes
Copy link
Member

@jsignanini jsignanini left a comment

@fcjr see comment
@jsignanini
jsignanini approved these changes Jan 4, 2021
View changes
@fcjr fcjr marked this pull request as ready for review Jan 4, 2021
@fcjr fcjr requested a review from ghostery/extension as a code owner Jan 4, 2021
@christophertino
christophertino approved these changes Jan 4, 2021
View changes
@christophertino christophertino added this to the 8.5.5 milestone Jan 4, 2021
@chrmod
chrmod requested changes Jan 5, 2021
View changes
src/utils/api.js Outdated Show resolved Hide resolved
src/utils/api.js Outdated Show resolved Hide resolved
@chrmod
chrmod requested changes Jan 5, 2021
View changes
src/utils/api.js Outdated Show resolved Hide resolved
@chrmod chrmod mentioned this pull request Jan 5, 2021
Merged
fcjr added 3 commits Jan 5, 2021
@fcjr
fix isRefreshing invocation
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
935998f
@fcjr
move to main func, use finally
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
496448e
@fcjr
move window dispatch
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
4f90be7
@fcjr fcjr marked this pull request as draft Jan 5, 2021
@fcjr
handle previously unhandled fetch rejections
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
0ca6af2
@jsignanini
jsignanini reviewed Jan 5, 2021
View changes
src/utils/api.js Outdated Show resolved Hide resolved
fcjr added 2 commits Jan 5, 2021
@fcjr
refactor to use a single promise
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
f3d3ff8
@fcjr
Merge branch 'develop' into GIS-866_search_communication
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5d70dab
fcjr added 4 commits Jan 5, 2021
@fcjr
remove old event type
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
e49e6bc
@fcjr
Merge branch 'GIS-866_search_communication' of github.com:ghostery/gh…
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
c878115 
…ostery-extension into GIS-866_search_communication
@fcjr
handle refreshToken errors
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
d8219d2
@fcjr
update cc
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
8e7bebd
@fcjr fcjr marked this pull request as ready for review Jan 6, 2021
@fcjr fcjr requested review from chrmod and jsignanini Jan 6, 2021
@jsignanini
Merge branch 'develop' into GIS-866_search_communication
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
eea4e9d
@jsignanini
jsignanini approved these changes Jan 6, 2021
View changes
@chrmod
chrmod approved these changes Jan 7, 2021
View changes
@christophertino christophertino merged commit e648593 into develop Jan 7, 2021
2 checks passed
2 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@christophertino christophertino deleted the GIS-866_search_communication branch Jan 7, 2021
chrmod added a commit to ghostery/user-agent-desktop that referenced this pull request Jan 7, 2021
@chrmod
Search addon version bump
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
89cc30c 
ghostery/ghostery-search-extension#39
ghostery/ghostery-extension#647
@chrmod chrmod mentioned this pull request Jan 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrmod chrmod

@jsignanini jsignanini

@christophertino christophertino

@wlycdgr wlycdgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@fcjr @chrmod @jsignanini @christophertino @wlycdgr