Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIS-866: Search Communication #647

Merged
merged 17 commits into from Jan 7, 2021

ensure browser info is populated

  • Loading branch information
fcjr committed Dec 24, 2020
commit b225f5899b74dff9d6a7764dac590c45752802bb
@@ -1651,12 +1651,15 @@ function initializeGhosteryModules() {
}

/**
* Initialize Search Message Handler.
* Initialize Search Message Handler on Ghostery Browser.
* @memberOf Background
*/
function initializeSearchMessageHandler() {
const sm = new SearchMessager();
sm.init();
async function initializeSearchMessageHandler() {
await globals.BROWSER_INFO_READY; // ensure browser info is set
if (IS_GHOSTERY_BROWSER) {
This conversation was marked as resolved by christophertino

This comment has been minimized.

@christophertino

christophertino Jan 4, 2021
Member

change to BROWSER_INFO.name === 'ghostery_desktop'

const sm = new SearchMessager();
sm.init();
}
}

/**
@@ -1670,9 +1673,7 @@ function init() {
initializePopup();
initializeEventListeners();
initializeVersioning();
if (IS_GHOSTERY_BROWSER) {
initializeSearchMessageHandler();
}
initializeSearchMessageHandler();
return metrics.init(globals.JUST_INSTALLED).then(() => initializeGhosteryModules().then(() => {
account.migrate()
.then(() => {
ProTip! Use n and p to navigate between commits in a pull request.