Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIS-866: Search Communication #647
GIS-866: Search Communication #647
Changes from 1 commit
653632e0985b0f0e51222952a9f4b225f583e28136935998f496448e4f90be70ca6af2f3d3ff85d70dabe49e6bcc878115d8219d28e7bebdeea4e9dFile filter
Jump to
refactor to use a single promise
Verified
jsignaniniJan 4, 2021
Member
@fcjr I'm thinking renaming this to something like
refreshTokenAndHandleIsRefreshingto make it super clear what the purpose of this new function isfcjrJan 4, 2021
Author
Member
That sounds reasonable, I'll make the change. My thought with just naming it
refreshTokenwas that as an external user of the api class the inner "isRefreshing" state is an implementation detail that external users of the function don't really need to know about, but since this should only be used in special cases anyways there shouldn't be a harm in making it explicitjsignaniniJan 4, 2021
Member
@fcjr actually you do make a good point as it’s only used internally in the other “private” function. Ok you can just leave it as is then. Thanks.