Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/yarn #65

Merged
merged 7 commits into from May 17, 2018
Merged

feature/yarn #65

merged 7 commits into from May 17, 2018

Conversation

@trickpattyFH20
Copy link
Contributor

@trickpattyFH20 trickpattyFH20 commented May 17, 2018

  • nvm install will now resolve to node LTS
  • CI environments now all using node LTS and yarn
  • readme updated for yarn

TODO

  • local builds should migrate to yarn
  • MOAB should migrate to yarn
jsignanini and others added 4 commits May 10, 2018
@trickpattyFH20 trickpattyFH20 requested a review from ghostery/ghostery as a code owner May 17, 2018
.nvmrc Outdated
@@ -0,0 +1 @@
lts/*

This comment has been minimized.

@jsignanini

jsignanini May 17, 2018
Member

@trickpattyFH20 let's replace this with the specific latest lts lts/carbon to be sure we're all on the same version.

.travis.yml Outdated
@@ -1,15 +1,15 @@
language: node_js
node_js:
- "9"
- "lts/*"

This comment has been minimized.

@jsignanini

jsignanini May 17, 2018
Member

@trickpattyFH20 same as above comment here.

jsignanini added 2 commits May 17, 2018
@jsignanini jsignanini merged commit 0480340 into develop May 17, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/yarn branch May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants