GH-2220: Onboarding - Telemetry #650
Merged
Conversation
…Step to use OnboardingConstants. Add react-router to onboarding hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
setup_stepand pingsgb_onboardingwhen a step is completed (specifically on thenextbutton handler for each page)gb_onboarding_successwhen clicking theLet's Searchbutton on theSuccessscreenStep3_ChooseDefaultSearchas the page is not yet created (Left a TODO)setSetupStep()to update the conf value when theStepNavigationroutes to a previous/next page. Should we handle this so users don't skip steps?shared-hubapp withreact-routerso we can navigate usinghistory.push('example-route')