Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2220: Onboarding - Telemetry #650

Merged
merged 7 commits into from Jan 4, 2021
Merged

GH-2220: Onboarding - Telemetry #650

merged 7 commits into from Jan 4, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Dec 31, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Updates setup_step and pings gb_onboarding when a step is completed (specifically on the next button handler for each page)
  • Pings gb_onboarding_success when clicking the Let's Search button on the Success screen
  • Does not set the setup step for Step3_ChooseDefaultSearch as the page is not yet created (Left a TODO)
  • Does not call setSetupStep() to update the conf value when the StepNavigation routes to a previous/next page. Should we handle this so users don't skip steps?
  • Surrounds the shared-hub app with react-router so we can navigate using history.push('example-route')
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Dec 31, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Dec 31, 2020
@benstrumeyer benstrumeyer self-assigned this Dec 31, 2020
@benstrumeyer benstrumeyer requested review from christophertino and ghostery/extension as code owners Dec 31, 2020
@wlycdgr
wlycdgr approved these changes Jan 4, 2021
@wlycdgr wlycdgr merged commit 38601b9 into ghostery-browser-intro-hub Jan 4, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the GH-2220 branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants