Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2218: Browser Onboarding Copy Edits & Tooltips #652

Merged
merged 6 commits into from Jan 5, 2021
Merged

GH-2218: Browser Onboarding Copy Edits & Tooltips #652

merged 6 commits into from Jan 5, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jan 5, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Updates the copies on all pages
  • Adds messages for Choose Your Search
  • Adds tooltips for BlockSettings
benstrumeyer added 6 commits Jan 5, 2021
@benstrumeyer
Add tooltips for BlockSettingsView and move <Tooltip /> to shared-hub…
995d139 
…. Remove some unused translation messages
@benstrumeyer
Remove unused svgs
Loading status checks…
7c90444
@benstrumeyer
Remove unused scss
Loading status checks…
1f57859
@benstrumeyer
Add messages for step 3 choose your search
Loading status checks…
5b66e96
@benstrumeyer
Merge branch 'ghostery-browser-intro-hub' into GH-2218
Loading status checks…
737047c
@benstrumeyer
Add back message
Loading status checks…
c22d92f
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Jan 5, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Jan 5, 2021
@benstrumeyer benstrumeyer self-assigned this Jan 5, 2021
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Jan 5, 2021
@wlycdgr
wlycdgr approved these changes Jan 5, 2021
View changes
@wlycdgr wlycdgr merged commit a9e9cf2 into ghostery-browser-intro-hub Jan 5, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Feature Enhancement
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@benstrumeyer @wlycdgr