Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery Dawn Intro Hub Miscellaneous Fixes #653

Merged
merged 21 commits into from Jan 7, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jan 6, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Add back button to each page except Welcome Screen
  • If the user wants to return to Step 1 - Sign In via the Step Progress Bar or Step 2 back button, they will be logged out
  • Adds back translation string, already in GH-2218
  • Prevents user from using the StepProgressBar to move forwards, only back
  • Every screen should be responsive except Step 3 - Choose Your Search
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Jan 6, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Jan 6, 2021
@benstrumeyer benstrumeyer self-assigned this Jan 6, 2021
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Jan 6, 2021
@wlycdgr
wlycdgr approved these changes Jan 7, 2021
@wlycdgr wlycdgr merged commit 9100e95 into ghostery-browser-intro-hub Jan 7, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the misc-fixes branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants