Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2244: Unit tests for Ghostery Dawn Intro Hub #657

Merged
merged 24 commits into from Jan 19, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jan 12, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Add tests for WelcomeView, LoginFormContainer, LoginFormView, CreateAccountView, BlockSettingsView, ChoosePlanView, SuccessView, and StepProgressBar
  • Did not add test for ChooseDefaultSearchView
  • Add tests for corresponding actions and reducers
  • Update index of StepNavigation to be a string from OnboardingConstants
  • Update PropTypes
  • Add license to sass files
  • Remove withRouter() from Step1_CreateAccountView since buildReduxHOC already has it
  • Fix bug on ChoosePlanView where cards were not shown for a basic user
  • Update copyright year for the intro hub
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Jan 12, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Jan 12, 2021
@benstrumeyer benstrumeyer self-assigned this Jan 12, 2021
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Jan 12, 2021
Copy link
Member

@wlycdgr wlycdgr left a comment

A few cleanup-type comments and a couple spots where the reducer tests MAY give false reassurance

… AntiSuiteReducer tests, and mock nested functions in action tests
@benstrumeyer benstrumeyer requested a review from wlycdgr Jan 14, 2021
@wlycdgr wlycdgr merged commit 359b7c2 into ghostery-browser-intro-hub Jan 19, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the ghostery-browser-intro-hub-tests branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants