GH-2244: Unit tests for Ghostery Dawn Intro Hub #657
Merged
+2,474
−72
Conversation
…boarding Constants as an index to appease PropTypes
|
A few cleanup-type comments and a couple spots where the reducer tests MAY give false reassurance |
...Views/Step1_CreateAccountForm/__tests__/Step1_CreateAccountForm.test.jsx
Outdated
Show resolved
Hide resolved
...Views/Step1_CreateAccountForm/__tests__/Step1_CreateAccountForm.test.jsx
Outdated
Show resolved
Hide resolved
...Views/Step1_CreateAccountForm/__tests__/Step1_CreateAccountForm.test.jsx
Outdated
Show resolved
Hide resolved
...stery-browser-hub/Views/OnboardingViews/Step1_CreateAccountView/index.js
Show resolved
Hide resolved
...Views/OnboardingViews/Step1_LogInForm/__tests__/Step1_LoginForm.test.jsx
Outdated
Show resolved
Hide resolved
...s/OnboardingViews/Step4_ChoosePlanView/__tests__/ChoosePlanView.test.jsx
Outdated
Show resolved
Hide resolved
… AntiSuiteReducer tests, and mock nested functions in action tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
WelcomeView,LoginFormContainer,LoginFormView,CreateAccountView,BlockSettingsView,ChoosePlanView,SuccessView, andStepProgressBarChooseDefaultSearchViewStepNavigationto be a string fromOnboardingConstantswithRouter()fromStep1_CreateAccountViewsincebuildReduxHOCalready has itChoosePlanViewwhere cards were not shown for a basic user