Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2236: Update onboarding branding #658

Merged

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Jan 12, 2021

Changes copy and logos in order to implement the new branding for the browser and search. Though the install loading modal screen is not implemented yet, I added the text for the heading, in messages.json, where the copy change is supposed to go.

Also made some small CSS changes to pull certain things more in line with the Zeplin designs.


  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@leuryr leuryr requested a review from ghostery/extension as a code owner Jan 12, 2021
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM for merging into onboarding branch

@wlycdgr wlycdgr merged commit e6e4392 into ghostery-browser-intro-hub Jan 12, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@christophertino christophertino added this to the 8.5.5 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants