Remove updates and promotions checkbox and dropdown #659
Conversation
Contributor
benstrumeyer
commented
Jan 13, 2021
|
…e user to emails upon registering in the hub instead
benstrumeyer
changed the title
|
May need to restore Learn More expandable drawer logic depending on final UX decision on that. If that DID get cut, then ignore that comment! |
| @@ -38,4 +38,4 @@ export const GET_USER_SUBSCRIPTION_DATA_FAIL = 'GET_USER_SUBSCRIPTION_DATA_FAIL' | |||
| export const GET_USER_SUBSCRIPTION_DATA_SUCCESS = 'GET_USER_SUBSCRIPTION_DATA_SUCCESS'; | |||
|
|
|||
| // Opt into/out of updates and promotions sendgrid emails | |||
| export const ACCOUNT_DATA_EMAIL_PREFERENCES_CHECKBOX_CHANGE = 'ACCOUNT_DATA_EMAIL_PREFERENCES_CHECKBOX_CHANGE'; | |||
wlycdgr
Jan 13, 2021
Member
Same deal, just double checking this isn't being used anywhere else anymore. If not, and the user can no longer change their email preferences in the extension panel or either of the hubs, we should be able to dispense with the SUBSCRIBE_TO_EMAIL_LIST action also, no?
Same deal, just double checking this isn't being used anywhere else anymore. If not, and the user can no longer change their email preferences in the extension panel or either of the hubs, we should be able to dispense with the SUBSCRIBE_TO_EMAIL_LIST action also, no?
benstrumeyer
Jan 14, 2021
Author
Contributor
We actually don't have the functionality in the original hub or the panel to toggle sendgrid emails on, so this is only used here
We actually don't have the functionality in the original hub or the panel to toggle sendgrid emails on, so this is only used here
| @@ -164,7 +156,7 @@ class CreateAccountFormContainer extends Component { | |||
| if (success) { | |||
| // User is automatically logged in, and redirected to the logged in view of BrowserCreateAccountForm | |||
| actions.getUser().then(() => { | |||
| if (isUpdatesChecked) actions.handleEmailPreferencesCheckboxChange('global', isUpdatesChecked); | |||
| actions.subscribeToEmailList('global'); | |||
wlycdgr
Jan 13, 2021
Member
See above - we may not need this at all?
See above - we may not need this at all?
benstrumeyer
Jan 14, 2021
Author
Contributor
See comment above
See comment above
...iews/OnboardingViews/Step1_CreateAccountView/Step1_CreateAccountView.jsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.