Fixes for Dawn Onboarding toast messages #660
Merged
Conversation
|
One quick one |
| let dawnToastText = ''; | ||
| if (dawnHub && toastClass === 'alert') { | ||
| dawnToastText = 'Error: '; | ||
| } else if (dawnHub && toastClass === 'success') { | ||
| dawnToastText = 'Success: '; | ||
| } |
Comment on lines
30
to
35
wlycdgr
Jan 20, 2021
Member
We should make sure this is i18n-friendly
We should make sure this is i18n-friendly
leuryr
Jan 20, 2021
Author
Contributor
Ah, absolutely. Fixed! Means less lines of code in ToastMessage.jsx as well, so win-win, haha.
Ah, absolutely. Fixed! Means less lines of code in ToastMessage.jsx as well, so win-win, haha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR updates the toast styling to bring it in line with the Dawn Onboarding designs from Zeplin. Also:
Because this toast component is also used in our Ghostery extension, with its own distinct styling, I added an optional
dawnHubboolean prop (falseby default) forToastMessage.jsx, in order to change the styling if the component is coming from Dawn's onboarding.