Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Dawn Onboarding toast messages #660

Merged
merged 12 commits into from Jan 21, 2021

Add missing toast error message for Step 1

  • Loading branch information
leuryr committed Jan 13, 2021
commit a86ca654d4f27cb36626ad29fd89a559c6f53318
@@ -1740,6 +1740,9 @@
"hub_create_account_toast_error": {
"message": "That email address is already in use. Please choose another."
},
"ghostery_browser_hub_onboarding_toast_fix_errors": {
"message": "Please fix errors before proceeding."
},
"ghostery_browser_hub_onboarding_install_heading": {
"message": "Ghostery Dawn now installing..."
},
@@ -152,10 +152,15 @@ class CreateAccountFormContainer extends Component {
validateInput: true,
});

const { actions } = this.props;
if (!emailIsValid || !confirmIsValid || !legalConsentChecked || !passwordIsValid || confirmPasswordError) {
actions.setToast({
toastMessage: t('ghostery_browser_hub_onboarding_toast_fix_errors'),
toastClass: 'alert'
});
return;
}
const { actions } = this.props;

actions.setToast({
toastMessage: '',
toastClass: ''
ProTip! Use n and p to navigate between commits in a pull request.