Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Progress Bar Bug #661

Merged
merged 3 commits into from Jan 20, 2021
Merged

Step Progress Bar Bug #661

merged 3 commits into from Jan 20, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jan 20, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Fix bug where ghosties change positions
  • Fix cross browser bug where incompleted steps show 2 dotted lines
  • Make Progress Bar on step 4 smaller to adhere to the size on other pages for consistency
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Jan 20, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Jan 20, 2021
@benstrumeyer benstrumeyer self-assigned this Jan 20, 2021
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Jan 20, 2021
@wlycdgr wlycdgr merged commit c423fd7 into ghostery-browser-intro-hub Jan 20, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the step-progress-bar-fix branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants