Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Progress Bar Bug #661

Merged
merged 3 commits into from Jan 20, 2021
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next

Fix cross browser progress bar lines and reduce size of progress bar …

…on step 4
  • Loading branch information
benstrumeyer committed Jan 19, 2021
commit 34b451393040928c5876a4f28f63ed40153c24b8
@@ -57,6 +57,10 @@ const StepProgressBar = (props) => {
const currentStepNumber = parseInt(currentStep, 10);
const totalSteps = steps.length;

const progressBarContainerClasses = ClassNames('StepProgressBarContainer', {
step4: currentStepNumber === 4
});

const logoutIfStepOne = (stepId) => {
const { actions } = props;
const { logout } = actions;
@@ -121,7 +125,7 @@ const StepProgressBar = (props) => {
);

return (
<div className="StepProgressBarContainer">
<div className={progressBarContainerClasses}>
{(currentStep !== WELCOME) && renderProgressBar()}
</div>
);
@@ -18,7 +18,12 @@
align-items: center;
max-width: 800px;
margin: auto;
padding-top: 10px;
padding-top: 10px;

&.step4 {
max-width: 724px;
padding: 10px 20px 0 20px;
}
}

.StepProgressBar__Step {
@@ -91,7 +96,7 @@
border: solid 2px $ghosty-blue;
}
&.incompleted {
padding: 1em;
padding: 13px;
background-image:
radial-gradient(circle at 2.5px, $ghosty-blue 1.25px, rgba(255,255,255,0) 2.5px),
radial-gradient(circle, $ghosty-blue 1.25px, rgba(255,255,255,0) 2.5px),
ProTip! Use n and p to navigate between commits in a pull request.