Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leet tool character limits and misc fixes #662

Merged
merged 4 commits into from Jan 22, 2021
Merged

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jan 21, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Use leet tool to address large character limits
  • Make toast message z-index 30 (Top of hierarchy, above tooltips=20, modals=10) to fix this bug
    image
  • Make back button more responsive
  • Fix dots for large screen sizes
  • Add Passwords do not match error on account creation screen
  • Fix back button spacing (Always next to title, aligned with the step progress bar--character limits often push it upwards, but I think it looks okay)
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Jan 21, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Jan 21, 2021
@benstrumeyer benstrumeyer self-assigned this Jan 21, 2021
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Jan 21, 2021
@wlycdgr wlycdgr merged commit a1118ca into ghostery-browser-intro-hub Jan 22, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the leet-tool branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants