Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghostery Dawn Miscellaneous Bug fixes #664

Merged
merged 7 commits into from Jan 22, 2021
Merged

Ghostery Dawn Miscellaneous Bug fixes #664

merged 7 commits into from Jan 22, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jan 22, 2021 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Bold and change font numbers in step progress bar
  • Align BlockSettingsView checkbox per vinny, add click handler to label
  • Restore Already have account and Create Account strings
  • Close tab when clicking CTA button on SuccessView
  • Fix terms and agreements label position on Create Account Form
  • Clear toasts when clicking skip button on Login and CreateAccount views
@benstrumeyer
Bold numbers in step progress bar
6e4040b
@benstrumeyer
Align BlockSettingsView checkbox per vinny, add click handler to chec…
7beccd5 
…kbox label
@benstrumeyer
Restore already have account and create an account, also get rid of c…
46b3d42 
…onsole error
@benstrumeyer
Close tab when clicking CTA button on Success View
2a32674
@benstrumeyer
Fix terms and agreements label position on Create Account Form
Loading status checks…
b857a1b
@benstrumeyer
Update snapshots
Loading status checks…
3f5fd2b
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Jan 22, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Jan 22, 2021
@benstrumeyer benstrumeyer self-assigned this Jan 22, 2021
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Jan 22, 2021
@benstrumeyer
Clear toasts when clicking skip button
Loading status checks…
0ae3d86
@wlycdgr wlycdgr merged commit f1ba4f0 into ghostery-browser-intro-hub Jan 22, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@benstrumeyer benstrumeyer deleted the miscellaneous-fixes branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

@ghostery/extension Extension

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@benstrumeyer @wlycdgr