Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery Dawn Miscellaneous Bug fixes #664

Merged
merged 7 commits into from Jan 22, 2021

Close tab when clicking CTA button on Success View

  • Loading branch information
benstrumeyer committed Jan 22, 2021
commit 2a32674c63069b3f52349893e6afe44a40a566df
@@ -22,6 +22,12 @@ import { NavLink } from 'react-router-dom';
const SuccessView = (props) => {
const { actions } = props;
const { sendPing } = actions;

const handleCTAButtonClick = () => {
sendPing({ type: 'gb_onboarding_success' });
window.close();
};

return (
<Fragment>
<div className="SuccessView__relativeContainer">
@@ -37,7 +43,7 @@ const SuccessView = (props) => {

<div className="SuccessView__subtitle">{`${t('ghostery_dawn_onboarding_surf_with_ease')} Ghostery`}</div>
<img className="SuccessView__ghosterySuite" src="/app/images/hub/success/ghostery-suite.png" />
<button className="SuccessView__ctaButton" onClick={() => sendPing({ type: 'gb_onboarding_success' })} type="button">{t('ghostery_dawn_onboarding_start_browsing')}</button>
<button className="SuccessView__ctaButton" onClick={() => handleCTAButtonClick()} type="button">{t('ghostery_dawn_onboarding_start_browsing')}</button>
</div>
</Fragment>
);
ProTip! Use n and p to navigate between commits in a pull request.