Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2247: Add dropdown list of search options #667

Merged
merged 2 commits into from Jan 27, 2021

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Jan 26, 2021

Adds dropdown for additional search options users can set as default during Dawn onboarding. Unlike the standard default containers, the "Other" container only triggers the confirmation modal when a search option is selected from the dropdown.


  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@leuryr leuryr marked this pull request as ready for review Jan 26, 2021
@leuryr leuryr requested a review from ghostery/extension as a code owner Jan 26, 2021
@wlycdgr wlycdgr merged commit 7d32d5f into ghostery-browser-intro-hub Jan 27, 2021
0 of 2 checks passed
0 of 2 checks passed
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@christophertino christophertino added this to the 8.5.5 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants