setup_number ping parameter #669
Merged
Conversation
benstrumeyer
requested review from
christophertino and
ghostery/extension
as
code owners
|
Lemme know if you have any questions! |
...nboardingViews/Step3_ChooseDefaultSearchView/ChooseDefaultSearchView.jsx
Outdated
Show resolved
Hide resolved
...nboardingViews/Step3_ChooseDefaultSearchView/ChooseDefaultSearchView.jsx
Outdated
Show resolved
Hide resolved
...-hub/Views/OnboardingViews/Step2_BlockSettingsView/BlockSettingsView.jsx
Show resolved
Hide resolved
...-hub/Views/OnboardingViews/Step2_BlockSettingsView/BlockSettingsView.jsx
Outdated
Show resolved
Hide resolved
app/dawn-hub/Views/OnboardingViews/Step4_ChoosePlanView/ChoosePlanView.jsx
Outdated
Show resolved
Hide resolved
app/dawn-hub/Views/OnboardingViews/Step4_ChoosePlanView/ChoosePlanView.jsx
Outdated
Show resolved
Hide resolved
app/dawn-hub/Views/OnboardingViews/Step4_ChoosePlanView/ChoosePlanView.jsx
Outdated
Show resolved
Hide resolved
src/background.js
Outdated
| @@ -524,6 +524,7 @@ function handleGhosteryHub(name, message, callback) { | |||
| const origin = message.origin || ''; | |||
| if (origin === 'onboarding') { | |||
| conf.setup_step = message.setup_step; | |||
| conf.setup_number = message.setup_number; | |||
wlycdgr
Jan 28, 2021
Member
Even though we use the same Metrics qs param for both, can we store this setup_number in a new and separate conf prop to make the whole thing a bit less dirty? Maybe dawn_setup_number. Then in Metrics we would buildQueryPair with one or the other depending on which ping we were sending
Even though we use the same Metrics qs param for both, can we store this setup_number in a new and separate conf prop to make the whole thing a bit less dirty? Maybe dawn_setup_number. Then in Metrics we would buildQueryPair with one or the other depending on which ping we were sending
benstrumeyer
Jan 28, 2021
Author
Contributor
Good idea, changed to dawn_setup_number and made a function that cases on gb_onboarding
Good idea, changed to dawn_setup_number and made a function that cases on gb_onboarding
…dawn_setup_numbers
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
slping parameter in the dawn intro hub for each page according to https://ghostery.atlassian.net/wiki/spaces/BI/pages/488079383/Ghostery+Browser+-+Onboarding+Pings330ofChoosePlanView.jsx