Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup_number ping parameter #669
setup_number ping parameter #669
Changes from 1 commit
071e83517047d93e55b836c7ecffc5dbdb1cd479522053005d1c59239b5a66c2ae2f7d381ba916db22fd8ec0ab7d65d2b2623fc0c9ecaf06File filter
Jump to
Get rid of dawn_setup_number, replace with setup_number
wlycdgrJan 28, 2021
Member
Even though we use the same Metrics qs param for both, can we store this
setup_numberin a new and separate conf prop to make the whole thing a bit less dirty? Maybedawn_setup_number. Then inMetricswe wouldbuildQueryPairwith one or the other depending on which ping we were sendingbenstrumeyerJan 28, 2021
Author
Contributor
Good idea, changed to
dawn_setup_numberand made a function that cases ongb_onboarding