Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_number ping parameter #669

Merged
merged 16 commits into from Jan 29, 2021
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Get rid of dawn_setup_number, replace with setup_number

  • Loading branch information
benstrumeyer committed Jan 26, 2021
commit 17047d9d747fd858f647410508caf2e60ebc1493
@@ -524,6 +524,7 @@ function handleGhosteryHub(name, message, callback) {
const origin = message.origin || '';
if (origin === 'onboarding') {
conf.setup_step = message.setup_step;
conf.setup_number = message.setup_number;

This comment has been minimized.

@wlycdgr

wlycdgr Jan 28, 2021
Member

Even though we use the same Metrics qs param for both, can we store this setup_number in a new and separate conf prop to make the whole thing a bit less dirty? Maybe dawn_setup_number. Then in Metrics we would buildQueryPair with one or the other depending on which ping we were sending

This comment has been minimized.

@benstrumeyer

benstrumeyer Jan 28, 2021
Author Contributor

Good idea, changed to dawn_setup_number and made a function that cases on gb_onboarding

metrics.ping('gb_onboarding');
}
callback({ setup_step });
ProTip! Use n and p to navigate between commits in a pull request.