Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_number ping parameter #669

Merged
merged 16 commits into from Jan 29, 2021
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Add back in subscriptionType ping param...

  • Loading branch information
benstrumeyer committed Jan 27, 2021
commit cd47952ba36fb11845f49056f98dc1f440d62d34
@@ -257,7 +257,8 @@ class Metrics {
this._buildQueryPair('id', conf.install_date) +
// Showing campaign messages (former show_cmp)
this._buildQueryPair('sc', conf.show_cmp ? '1' : '0') +
// Subscription Typerics._getSubscriptionType().toString()) +
// Subscription Type
this._buildQueryPair('st', Metrics._getSubscriptionType().toString()) +
This conversation was marked as resolved by wlycdgr
Comment on lines +260 to +261

This comment has been minimized.

@wlycdgr

wlycdgr Jan 28, 2021
Member

Thank you!!

This comment has been minimized.

@benstrumeyer

benstrumeyer Jan 28, 2021
Author Contributor

Scary!


// New parameters for Ghostery 8.5.2
// Subscription Interval
ProTip! Use n and p to navigate between commits in a pull request.