ghostery / ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix certain block settings not setting #672

Merged

wlycdgr merged 2 commits into ghostery-browser-intro-hub from block-settings-fix

Jan 29, 2021

Contributor

leuryr commented Jan 29, 2021 •

edited

Fixes Anti-Tracking, Ad-Blocking, and Smart-Browsing not setting after the user makes selections in onboarding flow.

Changes to the setting variable names were made to make it easier to send that data over to Redux and our message handling functions.

Have you followed the guidelines in CONTRIBUTING.md?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you added an explanation of what your changes do?
Does your submission pass tests?
Did you lint your code prior to submission?

leuryr added 2 commits


            Fix certain block settings not saving

afd1bc2


            Test update

d45f316

leuryr requested a review from wlycdgr as a code owner

wlycdgr approved these changes

Member

wlycdgr left a comment

Looks good

wlycdgr merged commit b23a933 into ghostery-browser-intro-hub

christophertino added this to the 8.5.5 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment