Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2269, GIS-904: Allow account to trigger dawn hub #673

Merged
merged 9 commits into from Feb 5, 2021

Conversation

@fcjr
Copy link
Member

@fcjr fcjr commented Feb 2, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
fcjr added 4 commits Feb 1, 2021
@fcjr fcjr marked this pull request as ready for review Feb 2, 2021
@fcjr fcjr requested review from christophertino, wlycdgr and ghostery/extension as code owners Feb 2, 2021
@fcjr fcjr requested a review from jsignanini Feb 2, 2021
@fcjr fcjr self-assigned this Feb 2, 2021
@fcjr fcjr requested a review from benstrumeyer Feb 2, 2021
@fcjr fcjr removed their assignment Feb 3, 2021
@wlycdgr wlycdgr changed the title GIS-904: Allow account to trigger dawn hub (INCLUDE in 8.5.5) GIS-904: Allow account to trigger dawn hub Feb 4, 2021
const { history } = this.props;
history.push(`/${ONBOARDING}/${WELCOME}`);

Comment on lines 52 to 54

This comment has been minimized.

@wlycdgr

wlycdgr Feb 4, 2021
Member

Since we are removing this and users will start at the root by defualt, we need an entry for the root path in the steps array in OnboardingViewContainer#render

@wlycdgr wlycdgr changed the title (INCLUDE in 8.5.5) GIS-904: Allow account to trigger dawn hub GIS-904: Allow account to trigger dawn hub Feb 4, 2021
fcjr added 2 commits Feb 4, 2021
@fcjr fcjr requested a review from wlycdgr Feb 4, 2021
@fcjr fcjr changed the title GIS-904: Allow account to trigger dawn hub GH-2269, GIS-904: Allow account to trigger dawn hub Feb 5, 2021
@christophertino christophertino added this to the 8.5.5 milestone Feb 5, 2021
@fcjr fcjr changed the title GH-2269, GIS-904: Allow account to trigger dawn hub (INCLUDE in 8.5.5) GH-2269, GIS-904: Allow account to trigger dawn hub Feb 5, 2021
@wlycdgr
wlycdgr approved these changes Feb 5, 2021
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM

@christophertino christophertino changed the title (INCLUDE in 8.5.5) GH-2269, GIS-904: Allow account to trigger dawn hub GH-2269, GIS-904: Allow account to trigger dawn hub Feb 5, 2021
@christophertino christophertino merged commit da4c511 into develop Feb 5, 2021
@christophertino christophertino deleted the GIS-904_search_opt_out branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants