Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2269, GIS-904: Allow account to trigger dawn hub #673

Merged
merged 9 commits into from Feb 5, 2021
+22 −3
Merged

GH-2269, GIS-904: Allow account to trigger dawn hub #673

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
48db0b5
allow account to open onboarding search selection page
fcjr Feb 1, 2021
4ee48b4
only trigger hub if within dawn
fcjr Feb 2, 2021
82099cc
dont force redirect user to the begining of oboarding
fcjr Feb 2, 2021
4d527a2
use constants
fcjr Feb 2, 2021
e049a27
Merge branch 'develop' into GIS-904_search_opt_out
fcjr Feb 2, 2021
46a5590
Merge branch 'develop' into GIS-904_search_opt_out
fcjr Feb 4, 2021
ff3d70c
add dontReroute param
fcjr Feb 4, 2021
50557e0
Merge branch 'develop' into GIS-904_search_opt_out
fcjr Feb 4, 2021
7b44821
Merge branch 'develop' into GIS-904_search_opt_out
fcjr Feb 5, 2021
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next

dont force redirect user to the begining of oboarding

  • Loading branch information
@fcjr
fcjr committed Feb 2, 2021
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
commit 82099cca5e7dcb6e333c85313b3e790f0f49473d
3 app/dawn-hub/Views/OnboardingView/OnboardingViewContainer.jsx
View file
Open in desktop
@@ -49,9 +49,6 @@ class OnboardingViewContainer extends Component {
sendMountActions: false,
};

const { history } = this.props;
history.push(`/${ONBOARDING}/${WELCOME}`);

Comment on lines -52 to -54

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Feb 4, 2021
Member

Since we are removing this and users will start at the root by defualt, we need an entry for the root path in the steps array in OnboardingViewContainer#render
// TODO verify what document title we should use
const title = t('ghostery_dawn_onboarding_page_title');
window.document.title = title;
ProTip! Use n and p to navigate between commits in a pull request.