Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2220: Onboarding Telemetry #676

Merged
merged 3 commits into from Feb 3, 2021
Merged

GH-2220: Onboarding Telemetry #676

merged 3 commits into from Feb 3, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Feb 2, 2021 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • The onboarding telemetry setup_step numbers had an off by one error. I have fixed them to send the # of screen they are on as opposed to the screen they are going to
@benstrumeyer
Fix setup_step numbers
778601f
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Feb 2, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Feb 2, 2021
@benstrumeyer benstrumeyer self-assigned this Feb 2, 2021
@wlycdgr wlycdgr changed the title GH-2220: Onboarding Telemetry (INCLUDE in 8.5.5) GH-2220: Onboarding Telemetry Feb 3, 2021
@wlycdgr
wlycdgr reviewed Feb 3, 2021
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Looks good. One other quick change: in the process of clarifying the acceptance criteria for GH-2220, we realized that we intend to be sending the gb_onboarding_success ping as soon as the user reaches the Success screen, not when they click the CTA on it
@benstrumeyer
Use one time hook to send a ping when user reaches the success view page
e1173ff
@benstrumeyer benstrumeyer requested a review from wlycdgr Feb 3, 2021
@wlycdgr
wlycdgr approved these changes Feb 3, 2021
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Looks good
@benstrumeyer
Appease linter
bb65a01
@benstrumeyer benstrumeyer requested a review from wlycdgr Feb 3, 2021
@wlycdgr
wlycdgr approved these changes Feb 3, 2021
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

lgtm
@christophertino
christophertino approved these changes Feb 3, 2021
View changes
@christophertino christophertino merged commit 99555c3 into develop Feb 3, 2021
@christophertino christophertino deleted the GH-2220 branch Feb 3, 2021
@christophertino christophertino changed the title (INCLUDE in 8.5.5) GH-2220: Onboarding Telemetry GH-2220: Onboarding Telemetry Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @wlycdgr