Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2220: Onboarding Telemetry #676

Merged
merged 3 commits into from Feb 3, 2021
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next

Fix setup_step numbers

  • Loading branch information
benstrumeyer committed Feb 2, 2021
commit 778601f91c36851534ad80dce31a04f699acc6cf
@@ -29,7 +29,7 @@ const WelcomeView = (props) => {
<div className="WelcomeView__title">{t('ghostery_dawn_onboarding_welcome')}</div>
<div className="WelcomeView__subtitle">{t('ghostery_dawn_onboarding_welcome_message')}</div>
<img className="WelcomeView__rocketShip" src="/app/images/hub/welcome/rocketShip.png" />
<NavLink className="WelcomeView__ctaButton" to="/onboarding/1" onClick={() => setSetupStep({ setup_step: LOGIN, origin: WELCOME })}>
<NavLink className="WelcomeView__ctaButton" to="/onboarding/1" onClick={() => setSetupStep({ setup_step: WELCOME, origin: WELCOME })}>
<span>{t('ghostery_dawn_onboarding_lets_do_this')}</span>
</NavLink>
</div>
@@ -18,7 +18,7 @@ import { NavLink } from 'react-router-dom';
import Tooltip from '../../../../shared-components/Tooltip';
import RadioButton from '../../../../shared-components/RadioButton/RadioButton';
import ToggleCheckbox from '../../../../shared-components/ToggleCheckbox/ToggleCheckbox';
import { CHOOSE_DEFAULT_SEARCH, ONBOARDING } from '../../OnboardingView/OnboardingConstants';
import { BLOCK_SETTINGS, ONBOARDING } from '../../OnboardingView/OnboardingConstants';

/**
* @class Implement the Block Settings View for the Dawn Hub onboarding flow
@@ -119,7 +119,7 @@ class BlockSettingsView extends Component {
setBlockingPolicy({ blockingPolicy });

setSetupStep({
setup_step: CHOOSE_DEFAULT_SEARCH,
setup_step: BLOCK_SETTINGS,
dawn_setup_number: this.buildSetupNumberString(),
origin: ONBOARDING
});
@@ -16,7 +16,7 @@ import { NavLink } from 'react-router-dom';
import ClassNames from 'classnames';
import { alwaysLog } from '../../../../../src/utils/common';
import RadioButton from '../../../../shared-components/RadioButton';
import { ONBOARDING, CHOOSE_PLAN } from '../../OnboardingView/OnboardingConstants';
import { ONBOARDING, CHOOSE_DEFAULT_SEARCH, CHOOSE_PLAN } from '../../OnboardingView/OnboardingConstants';
import {
SEARCH_GHOSTERY,
SEARCH_BING,
@@ -162,7 +162,7 @@ class ChooseDefaultSearchView extends Component {
setDefaultSearch(chosenSearchName);

setSetupStep({
setup_step: CHOOSE_PLAN,
setup_step: CHOOSE_DEFAULT_SEARCH,
dawn_setup_number: searchSetupNumbers.find(elem => elem.name === chosenSearchName).dawn_setup_number,
origin: ONBOARDING
});
ProTip! Use n and p to navigate between commits in a pull request.