Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2255: Allow Dawn's newtab extension to query GBE historical stats #677

Merged
merged 2 commits into from Feb 5, 2021
Merged

GH-2255: Allow Dawn's newtab extension to query GBE historical stats #677

merged 2 commits into from Feb 5, 2021

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Feb 2, 2021

Adds newtab@ghostery.com to the list of outside extensions that may query the GBE for historical stats. This is in support of displays historical stats info on new tab pages in Dawn.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Allow Dawn's newtab extesnion to query GBE historical stats
0f60afe
@wlycdgr wlycdgr requested review from christophertino and ghostery/extension as code owners Feb 2, 2021
@christophertino
christophertino approved these changes Feb 2, 2021
View changes
@fcjr fcjr changed the title GH-2255: Allow Dawn's newtab extesnion to query GBE historical stats GH-2255: Allow Dawn's newtab extension to query GBE historical stats Feb 3, 2021
@wlycdgr wlycdgr changed the title GH-2255: Allow Dawn's newtab extension to query GBE historical stats (DEFER until after 8.5.5) GH-2255: Allow Dawn's newtab extension to query GBE historical stats Feb 3, 2021
@christophertino christophertino changed the title (DEFER until after 8.5.5) GH-2255: Allow Dawn's newtab extension to query GBE historical stats GH-2255: Allow Dawn's newtab extension to query GBE historical stats Feb 5, 2021
@christophertino christophertino added this to the 8.5.5 milestone Feb 5, 2021
@christophertino
Merge branch 'develop' into GH-2255/feature/allow-dawn-to-query-histo…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
0c82b70 
…rical-stats
@christophertino christophertino merged commit ff1eb7b into develop Feb 5, 2021
@christophertino christophertino deleted the GH-2255/feature/allow-dawn-to-query-historical-stats branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino