Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2213 bugfix: Broken Next button #678

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Feb 4, 2021

Fixes bug where Next button would break if the internal name of the user's chosen search returned by browser.search.get() did not match any of our search engine name constants.

I added some protection to reduce the risk of unexpected values breaking our code, and added a new dawn_setup_number to use for cases when we don't recognize the chosen search.

Finally, I made a best guess for what the Search Encrypt internal name will turn out to be to improve the chance that we won't have to make a code change for this. If we start getting a lot of "unrecognized" pings once that engine is added on the Dawn side, we'll want to look here first.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@christophertino christophertino requested a review from benstrumeyer Feb 4, 2021
@christophertino christophertino added this to the 8.5.5 milestone Feb 4, 2021
Copy link
Contributor

@benstrumeyer benstrumeyer left a comment

LGTM, approved

@christophertino christophertino merged commit f13e50d into develop Feb 4, 2021
@christophertino christophertino deleted the bugfix/GH-2213/broken-next-button-on-search-selection-view branch Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants