GH-2213 bugfix: Broken Next button #678
Merged
Conversation
|
LGTM, approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes bug where Next button would break if the internal name of the user's chosen search returned by
browser.search.get()did not match any of our search engine name constants.I added some protection to reduce the risk of unexpected values breaking our code, and added a new
dawn_setup_numberto use for cases when we don't recognize the chosen search.Finally, I made a best guess for what the Search Encrypt internal name will turn out to be to improve the chance that we won't have to make a code change for this. If we start getting a lot of "unrecognized" pings once that engine is added on the Dawn side, we'll want to look here first.