Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2213 bugfix: Broken Next button #678

Merged
merged 6 commits into from Feb 4, 2021
+15 −7
Merged

GH-2213 bugfix: Broken Next button #678

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
446953c
Update alternative search engine identifiers to match name field vlue…
wlycdgr Feb 4, 2021
fbf8b8b
Guard against errors in case of unlisted or renamed chosen search
wlycdgr Feb 4, 2021
b89c7b8
Make a best guess for what Search Encrypt identifier will be
wlycdgr Feb 4, 2021
7abb306
Delete the Forbidden Blank Line
wlycdgr Feb 4, 2021
ae263d6
Look for search engine name using ds-appropriate array method
wlycdgr Feb 4, 2021
5bfadf0
Remove console logs
wlycdgr Feb 4, 2021
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next

Delete the Forbidden Blank Line

  • Loading branch information
@wlycdgr
wlycdgr committed Feb 4, 2021
commit 7abb306dccf66db01bbf71c1e8f2f7f4faaa6d49
1 ...n-hub/Views/OnboardingViews/Step3_ChooseDefaultSearchView/ChooseDefaultSearchConstants.js
View file
Open in desktop
@@ -28,4 +28,3 @@ export const SEARCH_QWANT = 'Qwant';
export const SEARCH_ENCRYPT = 'SearchEncrypt'; // TODO this is just our best guess. Once Search Encrypt is added on the Dawn side, we should confirm, particularly if we start getting a lot of DAWN_SETUP_NUMBER_FOR_UNLISTED_OR_RENAMED_SEARCH pings
export const SEARCH_TAILCAT = 'Tailcat';
export const SEARCH_OTHER = t('ghostery_dawn_onboarding_other');

ProTip! Use n and p to navigate between commits in a pull request.