Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2213: Step 3 - Fix setting ghostery as default search #679

Merged
merged 4 commits into from Feb 5, 2021
Merged

GH-2213: Step 3 - Fix setting ghostery as default search #679

merged 4 commits into from Feb 5, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Feb 5, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • The constant for selecting ghostery glow search has been updated from Ghostery -> Ghostery Glow. I've updated the constant accordingly and made a fix for displaying the svg
benstrumeyer added 3 commits Feb 5, 2021
@benstrumeyer
Update ghostery search constant
1656a66
@benstrumeyer
Fix ghostery svg
7250513
@benstrumeyer
Fix svg resolving errors
2ecf8db
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Feb 5, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Feb 5, 2021
@benstrumeyer benstrumeyer self-assigned this Feb 5, 2021
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Feb 5, 2021
@wlycdgr
Merge in develop
717aa79
@wlycdgr
wlycdgr approved these changes Feb 5, 2021
View changes
@christophertino christophertino changed the title (INCLUDE in 8.5.5) GH-2213: Step 3 - Fix setting ghostery as default search GH-2213: Step 3 - Fix setting ghostery as default search Feb 5, 2021
@christophertino christophertino merged commit 56dc7ce into develop Feb 5, 2021
@christophertino christophertino deleted the fix-ghostery-search branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino