Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2258: Preserve user onboarding settings #681

Merged
merged 10 commits into from Mar 15, 2021

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Feb 8, 2021

Keeps user settings for Blocking and Default Search when the user returns to those screens with Back.

  • Adds blockSetupSeen and searchSetupSeen to Redux in order to track if the user has previously visited the settings page and the old selections should be displayed, in addition to respective actions to update them.
  • Changes some of the Redux keys in order to prevent any issues when pulling in state through props that have the same key names

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@leuryr leuryr requested review from wlycdgr and ghostery/extension as code owners Feb 8, 2021
@wlycdgr wlycdgr changed the title GH-2258: Preserve user onboarding settings (8.5.6) (REVIEW ONGOING) GH-2258: Preserve user onboarding settings Feb 9, 2021
@wlycdgr wlycdgr changed the title (8.5.6) (REVIEW ONGOING) GH-2258: Preserve user onboarding settings (8.5.6) (TO BE REVIEWED) GH-2258: Preserve user onboarding settings Feb 9, 2021
Copy link
Member

@wlycdgr wlycdgr left a comment

Lemme know if you have any questions on the comments! Two other quick things for the BlockSettingsView:

  • "Recommended Choices" checkbox should be checked if the user's choices match what is recommended
  • "Recommended Choices" checkbox should become unchecked if the user changes their choice such that they no longer exactly match the recommended settings (this one isn't specific to this PR but would just be a nice bit of cleanup while we're at it)
@wlycdgr wlycdgr changed the title (8.5.6) (TO BE REVIEWED) GH-2258: Preserve user onboarding settings (8.5.6) (REVIEWED; COMMENTS TO BE ADDRESSED) GH-2258: Preserve user onboarding settings Feb 9, 2021
@christophertino christophertino added this to the 8.5.6 milestone Feb 10, 2021
@leuryr leuryr requested a review from wlycdgr Feb 23, 2021
@wlycdgr wlycdgr changed the title (8.5.6) (REVIEWED; COMMENTS TO BE ADDRESSED) GH-2258: Preserve user onboarding settings GH-2258: Preserve user onboarding settings Mar 8, 2021
Copy link
Member

@wlycdgr wlycdgr left a comment

Just a couple more changes!

@wlycdgr wlycdgr changed the title GH-2258: Preserve user onboarding settings (COMMENTS BEING ADDRESSED) GH-2258: Preserve user onboarding settings Mar 9, 2021
@wlycdgr wlycdgr changed the title (COMMENTS BEING ADDRESSED) GH-2258: Preserve user onboarding settings (COMMENTS) GH-2258: Preserve user onboarding settings Mar 9, 2021
@wlycdgr wlycdgr changed the title (COMMENTS) GH-2258: Preserve user onboarding settings (CHANGES SUGGESTED) GH-2258: Preserve user onboarding settings Mar 9, 2021
@wlycdgr wlycdgr changed the title (CHANGES SUGGESTED) GH-2258: Preserve user onboarding settings GH-2258: Preserve user onboarding settings Mar 11, 2021
leuryr and others added 2 commits Mar 11, 2021
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM!

@christophertino christophertino merged commit b15a542 into develop Mar 15, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the GH-2258/preserve_onb_settings branch Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants