GH-2258: Preserve user onboarding settings #681
Merged
+218
−95
Conversation
|
Lemme know if you have any questions on the comments! Two other quick things for the
|
...-hub/Views/OnboardingViews/Step2_BlockSettingsView/BlockSettingsView.jsx
Outdated
Show resolved
Hide resolved
...nboardingViews/Step3_ChooseDefaultSearchView/ChooseDefaultSearchView.jsx
Outdated
Show resolved
Hide resolved
...nboardingViews/Step3_ChooseDefaultSearchView/ChooseDefaultSearchView.jsx
Outdated
Show resolved
Hide resolved
|
Just a couple more changes! |
...-hub/Views/OnboardingViews/Step2_BlockSettingsView/BlockSettingsView.jsx
Outdated
Show resolved
Hide resolved
...-hub/Views/OnboardingViews/Step2_BlockSettingsView/BlockSettingsView.jsx
Outdated
Show resolved
Hide resolved
...-hub/Views/OnboardingViews/Step2_BlockSettingsView/BlockSettingsView.jsx
Outdated
Show resolved
Hide resolved
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Keeps user settings for Blocking and Default Search when the user returns to those screens with Back.
blockSetupSeenandsearchSetupSeento Redux in order to track if the user has previously visited the settings page and the old selections should be displayed, in addition to respective actions to update them.