Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2258: Preserve user onboarding settings #681

Merged
merged 10 commits into from Mar 15, 2021

Update tests and PropTypes

  • Loading branch information
leuryr committed Feb 22, 2021
commit 04e7348d4b0c7d33f1c80d0d4d502d379de89348
@@ -299,17 +299,10 @@ BlockSettingsView.propTypes = {
setBlockSetupSeen: PropTypes.func.isRequired,
}).isRequired,
setupLifecycle: PropTypes.shape({
blockingPolicy: PropTypes.string.isRequired,
enable_anti_tracking: PropTypes.bool.isRequired,
enable_ad_block: PropTypes.bool.isRequired,
enable_smart_block: PropTypes.bool.isRequired,
blockSetupSeen: PropTypes.bool.isRequired,
searchSetupSeen: PropTypes.bool.isRequired,
}).isRequired,
antiSuite: PropTypes.shape({
enable_ad_block: PropTypes.bool.isRequired,
enable_anti_tracking: PropTypes.bool.isRequired,
enable_smart_block: PropTypes.bool.isRequired,
}).isRequired,
enable_ad_block: PropTypes.bool.isRequired,
enable_anti_tracking: PropTypes.bool.isRequired,
enable_smart_block: PropTypes.bool.isRequired,
blockingPolicy: PropTypes.string.isRequired
};
@@ -22,7 +22,13 @@ jest.mock('../../../../../shared-components/Tooltip');

describe('app/dawn-hub/Views/OnboardingViews/Step2_BlockSettingsView/BlockSettingsView.test.jsx', () => {
const initialState = {
setupLifecycle: noop,
setupLifecycle: {
blockSetupSeen: false
},
blockingPolicy: '',
enable_ad_block: false,
enable_anti_tracking: false,
enable_smart_block: false,
actions: {
logout: noop,
setAntiTracking: noop,
@@ -16,11 +16,9 @@ import AntiSuiteReducer from '../AntiSuiteReducer';
import { SET_AD_BLOCK, SET_ANTI_TRACKING, SET_SMART_BLOCK } from '../../constants/AntiSuiteConstants';

const initialState = Immutable({
antiSuite: {
enable_ad_block: false,
enable_anti_tracking: false,
enable_smart_block: false
}
enable_ad_block: false,
enable_anti_tracking: false,
enable_smart_block: false
});

describe('app/shared-hub/reducers/AntiSuiteReducer', () => {
@@ -34,10 +32,10 @@ describe('app/shared-hub/reducers/AntiSuiteReducer', () => {
};
const action = { data, type: SET_AD_BLOCK };

const updatedAntiSuiteState = Immutable.merge(initialState.antiSuite, data);
const updatedAntiSuiteState = Immutable.merge(initialState, data);

expect(AntiSuiteReducer(initialState, action)).toEqual({
antiSuite: updatedAntiSuiteState
...updatedAntiSuiteState
});
});

@@ -47,10 +45,10 @@ describe('app/shared-hub/reducers/AntiSuiteReducer', () => {
};
const action = { data, type: SET_ANTI_TRACKING };

const updatedAntiSuiteState = Immutable.merge(initialState.antiSuite, data);
const updatedAntiSuiteState = Immutable.merge(initialState, data);

expect(AntiSuiteReducer(initialState, action)).toEqual({
antiSuite: updatedAntiSuiteState
...updatedAntiSuiteState
});
});

@@ -60,10 +58,10 @@ describe('app/shared-hub/reducers/AntiSuiteReducer', () => {
};
const action = { data, type: SET_SMART_BLOCK };

const updatedAntiSuiteState = Immutable.merge(initialState.antiSuite, data);
const updatedAntiSuiteState = Immutable.merge(initialState, data);

expect(AntiSuiteReducer(initialState, action)).toEqual({
antiSuite: updatedAntiSuiteState
...updatedAntiSuiteState
});
});
});
ProTip! Use n and p to navigate between commits in a pull request.