Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy #682

Merged
merged 5 commits into from Mar 15, 2021
Merged

GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy #682

merged 5 commits into from Mar 15, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Feb 8, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • GH-2262: Add caret to Create account Panel
  • GH-2257: Align checkbox and link in account creation panel
  • GH-2270: Update Welcome screen copy
benstrumeyer added 3 commits Feb 8, 2021
@benstrumeyer
Update welcome screen copy
b37588b
@benstrumeyer
Add arrow to skip button
a79978a
@benstrumeyer
Align privacy policy link with faq descriptions
2fce076
@benstrumeyer benstrumeyer requested a review from wlycdgr Feb 8, 2021
@benstrumeyer benstrumeyer requested a review from ghostery/extension as a code owner Feb 8, 2021
@benstrumeyer benstrumeyer self-assigned this Feb 8, 2021
@wlycdgr wlycdgr changed the title (DEFER until after 8.5.5) GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy (8.5.6) (TO BE REVIEWED) GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy Feb 9, 2021
@christophertino christophertino added this to the 8.5.6 milestone Feb 10, 2021
@wlycdgr wlycdgr changed the title (8.5.6) (TO BE REVIEWED) GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy (8.5.6) (IN REVIEW) GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy Feb 12, 2021
@wlycdgr wlycdgr changed the title (8.5.6) (IN REVIEW) GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy (IN REVIEW) GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy Feb 16, 2021
@wlycdgr wlycdgr changed the title (IN REVIEW) GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy GH-2262, GH-2257, GH-2270: Add caret, Align link, Update copy Mar 9, 2021
wlycdgr added 2 commits Mar 15, 2021
@wlycdgr
Merge in develop
Loading status checks…
1f9978b
@wlycdgr
Update CreateAccountView test snapshot
Loading status checks…
2bdf320
@wlycdgr wlycdgr requested review from leuryr and removed request for leuryr Mar 15, 2021
@wlycdgr
wlycdgr approved these changes Mar 15, 2021
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM
@christophertino
christophertino approved these changes Mar 15, 2021
View changes
@christophertino christophertino merged commit 0317946 into develop Mar 15, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the more-misc-fixes branch Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @wlycdgr