Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2232: Adjust design for translations #684

Merged
merged 1 commit into from Feb 10, 2021
Merged

GH-2232: Adjust design for translations #684

merged 1 commit into from Feb 10, 2021

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Feb 9, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Fix header overlapping back button on success screen
  • Fix option description on choose default search page
@benstrumeyer
Fix back button on success screen. Fix dropdown option description ov…
eeffe0a 
…erflowing to second line
@benstrumeyer benstrumeyer added this to the 8.5.5 milestone Feb 9, 2021
@benstrumeyer benstrumeyer requested a review from wlycdgr Feb 9, 2021
@benstrumeyer benstrumeyer self-assigned this Feb 9, 2021
@wlycdgr wlycdgr changed the title GH-2232: Adjust design for translations (8.5.5) GH-2232: Adjust design for translations Feb 10, 2021
@wlycdgr
wlycdgr approved these changes Feb 10, 2021
View changes
@wlycdgr wlycdgr changed the title (8.5.5) GH-2232: Adjust design for translations (8.5.5) (APPROVED) GH-2232: Adjust design for translations Feb 10, 2021
@wlycdgr wlycdgr changed the title (8.5.5) (APPROVED) GH-2232: Adjust design for translations (8.5.5) GH-2232: Adjust design for translations Feb 10, 2021
@christophertino christophertino changed the title (8.5.5) GH-2232: Adjust design for translations GH-2232: Adjust design for translations Feb 10, 2021
@christophertino
christophertino approved these changes Feb 10, 2021
View changes
@christophertino christophertino merged commit ea96af8 into develop Feb 10, 2021
@christophertino christophertino deleted the translation-fixes branch Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @wlycdgr