Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI from Travis to Github Actions #685

Merged
merged 23 commits into from Feb 11, 2021
Merged

Migrate CI from Travis to Github Actions #685

merged 23 commits into from Feb 11, 2021

Conversation

@fcjr
Copy link
Member

@fcjr fcjr commented Feb 10, 2021 •
edited

Due to changes with Travis lets migrate our CI to Github Actions.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@fcjr
migrate ci to github actions
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
ec667f1
@fcjr fcjr requested review from benstrumeyer, christophertino, wlycdgr and ghostery/extension as code owners Feb 10, 2021
@fcjr fcjr changed the base branch from master to develop Feb 10, 2021
@fcjr
fix folder name
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
cb0a3d5
@fcjr fcjr removed request for ghostery/extension, christophertino, benstrumeyer and wlycdgr Feb 10, 2021
fcjr added 2 commits Feb 10, 2021
@fcjr
fix node step
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
4cf5583
@fcjr
update job name
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
6f7f628
@fcjr fcjr closed this Feb 10, 2021
@fcjr fcjr reopened this Feb 10, 2021
@fcjr
checkout repo
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
ed392f8
@fcjr fcjr closed this Feb 10, 2021
@fcjr fcjr reopened this Feb 10, 2021
fcjr added 4 commits Feb 10, 2021
@fcjr
run on syncronize
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
d6ad850
@fcjr
test failed lint
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
e2bdf45
@fcjr
Revert "test failed lint"
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
e03958e 
This reverts commit e2bdf45.
@fcjr
fix test
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
c1629da
@fcjr fcjr requested review from wlycdgr and christophertino Feb 10, 2021
fcjr and others added 5 commits Feb 10, 2021
@fcjr
tmp
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
66d864c
@fcjr
rename because capitalizations are hard
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
cddc94b
@fcjr
remove snapshots
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
61e027a
@fcjr
add back snapshots with proper casing
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
d64e84f
@christophertino
clean up unit test logging
Verified
This commit was signed with the committer’s verified signature.
christophertino Christopher Tino
GPG key ID: 7DDE5EDA13A5D326 Learn about vigilant mode.
Loading status checks…
6406da8
@christophertino
Copy link
Member

@christophertino christophertino commented Feb 10, 2021

@wlycdgr Looks like we've got a couple proptype issues. Can you take a look?

yarn test app/dawn-hub/Views/OnboardingViews/Step4_ChoosePlanView/__tests__/ChoosePlanView.test.jsx

yarn test app/panel/components/Settings/__tests__/OptIn.jsx
@christophertino christophertino added this to the 8.5.5 milestone Feb 10, 2021
fcjr and others added 8 commits Feb 10, 2021
@fcjr
tmp
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
df30ffd
@fcjr
folder
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
2c183e7
@fcjr
tmp
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
43e597c
@fcjr
make consistent across plaforms
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
42e9d4d
@fcjr
Merge branch 'migrate_to_actions' of github.com:ghostery/ghostery-ext…
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
11a3750 
…ension into migrate_to_actions
@wlycdgr
Fix proptype issue with OptIn component tests
88fa662
@wlycdgr
Merge branch 'migrate_to_actions' of github.com:ghostery/ghostery-ext…
Loading status checks…
94f8a94 
…ension into migrate_to_actions
@wlycdgr
Fix ChoosePlanView component test proptype mismatch
Loading status checks…
faf1650
@wlycdgr
wlycdgr reviewed Feb 10, 2021
View changes
.github/workflows/LintAndTest.yml Outdated Show resolved Hide resolved
src/utils/common.js Show resolved Hide resolved
@wlycdgr wlycdgr changed the title Migrate to CI from Travis to Github Actions (8.5.5) Migrate to CI from Travis to Github Actions Feb 10, 2021
@fcjr fcjr changed the title (8.5.5) Migrate to CI from Travis to Github Actions (8.5.5) Migrate to CI from Travis to Github Actions test Feb 10, 2021
@fcjr fcjr changed the title (8.5.5) Migrate to CI from Travis to Github Actions test (8.5.5) Migrate to CI from Travis to Github Actions Feb 10, 2021
@fcjr
remove edited trigger
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
342a6b7
@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Feb 10, 2021

LGTM
@christophertino
christophertino approved these changes Feb 11, 2021
View changes
@christophertino christophertino changed the title (8.5.5) Migrate to CI from Travis to Github Actions Migrate CI from Travis to Github Actions Feb 11, 2021
@christophertino christophertino merged commit 0d0b85c into develop Feb 11, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the migrate_to_actions branch Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@fcjr @christophertino @wlycdgr