Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2232: localization-related UI fixes #686

Merged
merged 8 commits into from Feb 12, 2021

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Feb 11, 2021

Fixes a number of localization-related UI issues in the new Dawn onboarding:

  • Improves handling of headers that break to a second line

  • Improves handling of create account form field labels that break to a second line

  • Ensures that button labels are not cut off and that button labels do not break to a second line

  • Improves layout consistency across onboarding views

  • Improves layout of search selection confirmation modals

  • Have you followed the guidelines in CONTRIBUTING.md?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Have you added an explanation of what your changes do?

  • Does your submission pass tests?

  • Did you lint your code prior to submission?

@wlycdgr wlycdgr requested a review from christophertino Feb 11, 2021
@wlycdgr wlycdgr changed the title (8.5.5) GH-2232: localization-related UI fixes (8.5.5) (TO BE REVIEWED) GH-2232: localization-related UI fixes Feb 12, 2021
@wlycdgr wlycdgr changed the title (8.5.5) (TO BE REVIEWED) GH-2232: localization-related UI fixes (8.5.5) (READY FOR REVIEW) GH-2232: localization-related UI fixes Feb 12, 2021
@christophertino christophertino added this to the 8.5.5 milestone Feb 12, 2021
@christophertino christophertino changed the title (8.5.5) (READY FOR REVIEW) GH-2232: localization-related UI fixes GH-2232: localization-related UI fixes Feb 12, 2021
@christophertino christophertino merged commit 286b7f9 into develop Feb 12, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the GH-2232/bugfix/translation-related-UI-issues branch Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants