Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2232: localization-related UI fixes #686

Merged
merged 8 commits into from Feb 12, 2021
Merged

GH-2232: localization-related UI fixes #686

merged 8 commits into from Feb 12, 2021
+96 −64

Commits on Feb 11, 2021

  1. Prevent Welcome CTA button from breaking to two lines with longer tra… 

    …nslated strings
    @wlycdgr
    wlycdgr committed Feb 11, 2021
    67ed262

  2. Improve layout when onboarding view headers break to a second line

    @wlycdgr
    wlycdgr committed Feb 11, 2021
    6c2c967

  3. Improve search option container formatting when translated descriptio… 

    …n copy breaks to a 2nd line
    @wlycdgr
    wlycdgr committed Feb 11, 2021
    c93d82d

  4. Make layout of search selection confirmation modals look better and m… 

    …ore consistent across locales
    @wlycdgr
    wlycdgr committed Feb 11, 2021
    b19f3da

  5. Refine search selection modal layout to guard against element overlap… 

    …s at narrow widths. Rework plan selection header CSS to guard against element overlaps at narrow widths and across locales
    @wlycdgr
    wlycdgr committed Feb 11, 2021
    148b3a2

  6. Update test snapshot

    @wlycdgr
    wlycdgr committed Feb 11, 2021
    4b89786

  7. Make sure Start Trial CTA button label fully visible in other languag… 

    …es. Other minor adjustment to Select Plan view layout to better deal with string length variation.
    @wlycdgr
    wlycdgr committed Feb 11, 2021
    ccbf17d

  8. Prevent UI breakage if Create Account form field labels break to a se… 

    …cond line
    @wlycdgr
    wlycdgr committed Feb 11, 2021
    cd545dc