Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2232: localization-related UI fixes #686

Merged
merged 8 commits into from Feb 12, 2021

Refine search selection modal layout to guard against element overlap…

…s at narrow widths. Rework plan selection header CSS to guard against element overlaps at narrow widths and across locales
  • Loading branch information
wlycdgr committed Feb 11, 2021
commit 148b3a20e1c7c9272f76d6d42a0626167be9b6d4
@@ -290,7 +290,7 @@
}

.ChooseSearchView__modalOptionLogo {
padding-bottom: 70px;
padding-bottom: 40px;
}

.ChooseSearchView__modalDawnLogo {
@@ -301,11 +301,11 @@
.ChooseSearchView__modalDescription {
font-size: 24px;
font-weight: 500;
line-height: 1.75;
line-height: 1.6;
text-align: center;
color: $tundora;
width: 70%;
margin-bottom: 70px;
margin-bottom: 40px;
white-space: pre-line;
}

@@ -321,7 +321,7 @@ class ChoosePlanView extends React.Component {
const selectedGhosteryGlow = (defaultSearch === SEARCH_GHOSTERY);

return (
<div>
<Fragment>
<div className="ChoosePlanView__relativeContainer">
<div className="ChoosePlanView__backContainer">
<span className="ChoosePlanView__caret left" />
@@ -389,7 +389,7 @@ class ChoosePlanView extends React.Component {
</div>
)}
</div>
</div>
</Fragment>
);
}
}
@@ -35,7 +35,8 @@ $medium-large-breakpoint: 1118px; // Break when 3 cards on the screen overflow t
position: absolute;
display: flex;
width: 68px;
margin-top: 7px;
margin-top: 22px;
margin-left: 22px;
.ChoosePlanView__back {
margin-top: 8px;
font-size: 16px;
@@ -44,10 +45,11 @@ $medium-large-breakpoint: 1118px; // Break when 3 cards on the screen overflow t
}
}
.ChoosePlanView__yourPrivacyPlan {
margin: auto;
margin: 60px auto auto auto;
font-size: 24px;
display: flex;
justify-content: center;
text-align: center;
font-weight: 500;
}
.ChoosePlanView__subtitle {
ProTip! Use n and p to navigate between commits in a pull request.