Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2232: localization-related UI fixes #686

Merged
merged 8 commits into from Feb 12, 2021

Make layout of search selection confirmation modals look better and m…

…ore consistent across locales
  • Loading branch information
wlycdgr committed Feb 11, 2021
commit b19f3dafd3d171df107ebc902352052fe7c6755a
@@ -280,7 +280,7 @@ class ChooseDefaultSearchView extends Component {
return (
<Modal show>
<div className="ChooseSearchView__modalContent">
<img src="/app/images/hub/ChooseDefaultSearchView/ghostery-browser-logo.svg" />
<img className="ChooseSearchView__modalDawnLogo" src="/app/images/hub/ChooseDefaultSearchView/ghostery-browser-logo.svg" />
<div className="ChooseSearchView__modalMain">
{searchBeingConsidered === SEARCH_OTHER ? (
<div className="ChooseSearchView__modalHeader">
@@ -290,7 +290,12 @@
}

.ChooseSearchView__modalOptionLogo {
padding: 70px 0;
padding-bottom: 70px;
}

.ChooseSearchView__modalDawnLogo {
position: absolute;
top: 20px;
}

.ChooseSearchView__modalDescription {
@@ -300,11 +305,13 @@
text-align: center;
color: $tundora;
width: 70%;
margin-bottom: 113px;
white-space: pre-line;
margin-bottom: 70px;
white-space: pre-line;
}

.ChooseSearchView__modalContent {
display: flex;
align-items: center;
position: relative;
width: 901px;
min-height: 632px;
ProTip! Use n and p to navigate between commits in a pull request.