Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2298: Avoid possible race condition in ABTest & CMP on Dawn #687

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

GH-2298: Avoid possible race condition in ABTest & CMP on Dawn #687

wants to merge 3 commits into from

Conversation

@fcjr
Copy link
Member

@fcjr fcjr commented Feb 12, 2021 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@fcjr
await BROWSER_INFO_READY in CMP & ABTest
Verified
This commit was signed with the committer’s verified signature.
fcjr Frank Chiarulli Jr.
GPG key ID: 262758B51E7A9804 Learn about vigilant mode.
Loading status checks…
2679a61
@fcjr fcjr requested review from christophertino and wlycdgr as code owners Feb 12, 2021
@christophertino christophertino added this to the 8.5.6 milestone Feb 16, 2021
@wlycdgr wlycdgr changed the title Avoid possible race condition in ABTest & CMP on Dawn (TO BE REVIEWED) Avoid possible race condition in ABTest & CMP on Dawn Feb 16, 2021
@wlycdgr wlycdgr changed the title (TO BE REVIEWED) Avoid possible race condition in ABTest & CMP on Dawn Avoid possible race condition in ABTest & CMP on Dawn Feb 16, 2021
@fcjr
Merge branch 'develop' into avoid_race_condition
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
de7d733
@wlycdgr wlycdgr changed the title Avoid possible race condition in ABTest & CMP on Dawn GH-2298: Avoid possible race condition in ABTest & CMP on Dawn Mar 9, 2021
@wlycdgr
Merge in develop
Loading status checks…
c2ab60a
@wlycdgr
wlycdgr approved these changes Mar 9, 2021
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM. Smoke tested it and observed it working as expected in Chrome and Dawn
@wlycdgr wlycdgr modified the milestones: 8.5.6, 8.5.7 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.7
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@fcjr @wlycdgr @christophertino