Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry fix for create account ping #688

Merged
merged 2 commits into from Feb 16, 2021
Merged

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Feb 16, 2021

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Fix bug where clicking next after creating account sends the wrong telemetry ping
@benstrumeyer benstrumeyer requested a review from wlycdgr Feb 16, 2021
@benstrumeyer benstrumeyer self-assigned this Feb 16, 2021
@benstrumeyer benstrumeyer changed the title Fix telemetry for create account ping Telemetry fix for create account ping Feb 16, 2021
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM

@christophertino christophertino added this to the 8.5.5 milestone Feb 16, 2021
@christophertino christophertino merged commit d5dad51 into develop Feb 16, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the onboarding-telemetry-fix branch Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants