Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry fix for create account ping #688

Merged
merged 2 commits into from Feb 16, 2021
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next

Fix telemetry for create account ping

  • Loading branch information
benstrumeyer committed Feb 16, 2021
commit a054743e7cb0505244b9368aeaff2e6c67827a22
@@ -78,6 +78,7 @@ const Step1_CreateAccountView = (props) => {
};

const handleNextOnSelectPlanStep = () => {
console.log('test');
const { prev } = props;

setSetupStep({
@@ -114,15 +115,15 @@ const Step1_CreateAccountView = (props) => {
<div className="Step1_CreateAccountView__title">{t('ghostery_dawn_onboarding_you_are_signed_in_as')}</div>
<div className="Step1_CreateAccountView__email">{email}</div>
<div className="Step1_CreateAccountView__ctaButtonContainer">
{step === LOGIN && (
{view === SIGN_IN && (
<NavLink className="Step1_CreateAccountView__ctaButton" to="/onboarding/2" onClick={() => handleSkipButton(SIGN_IN_SUCCESSFUL)}>
<span>{t('next')}</span>
</NavLink>
)}
{step !== LOGIN && (
<div className="Step1_CreateAccountView__ctaButton" onClick={() => handleNextOnSelectPlanStep()}>
{view === CREATE_ACCOUNT && (
<NavLink className="Step1_CreateAccountView__ctaButton" to="/onboarding/2" onClick={() => handleNextOnSelectPlanStep()}>
<span>{t('next')}</span>
</div>
</NavLink>
)}
</div>
</div>
ProTip! Use n and p to navigate between commits in a pull request.