GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX #689
Conversation
|
One more thing aside from the comments above - I noticed the toast works when you sign out after signing into an existing account, but does not pop when you sign out after creating a new account. Let's make sure it pops in both scenarios. |
app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx
Outdated
Show resolved
Hide resolved
...iews/OnboardingViews/Step1_CreateAccountView/Step1_CreateAccountView.jsx
Show resolved
Hide resolved
Looks like this is still happening - could you take a look? Aside from not seeing the toast after creating a new account and then signing out, I'm actually also not seeing it after signing out if I signed in in the panel. I AM seeing it if I sign out after signing into an existing account in the onboarding. Other changes look good, thank you! |
|
Smoked it & LGTM |
Fixes the issue where the user is taken to the account creation/login step during onboarding even though they're already logged in through the extension.
A timeout has been added to give the user login info some time to reach the component before moving to the next step, without keeping that progression from happening if some error keeps the info from being fetched within that time for whatever reason. Open to implementing something a bit more elegant here if we'd rather have the user wait for this.