Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX #689

Merged
merged 8 commits into from Mar 16, 2021

Conversation

@leuryr
Copy link
Contributor

@leuryr leuryr commented Feb 16, 2021

Fixes the issue where the user is taken to the account creation/login step during onboarding even though they're already logged in through the extension.

A timeout has been added to give the user login info some time to reach the component before moving to the next step, without keeping that progression from happening if some error keeps the info from being fetched within that time for whatever reason. Open to implementing something a bit more elegant here if we'd rather have the user wait for this.

  • User is no longer logged out when they hit back from the block settings view page
  • An option to logout from the already logged in page has been added
  • A toast message has been added to notify the user when they log out

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@leuryr leuryr requested a review from wlycdgr as a code owner Feb 16, 2021
@wlycdgr wlycdgr changed the title GH-2273: Propagate login to Dawn onboarding (8.5.6) (TO BE REVIEWED) GH-2273: Propagate login to Dawn onboarding Feb 16, 2021
@wlycdgr wlycdgr added this to the 8.5.6 milestone Feb 16, 2021
@wlycdgr wlycdgr changed the title (8.5.6) (TO BE REVIEWED) GH-2273: Propagate login to Dawn onboarding (TO BE REVIEWED) GH-2273: Propagate login to Dawn onboarding Feb 16, 2021
@wlycdgr wlycdgr changed the title (TO BE REVIEWED) GH-2273: Propagate login to Dawn onboarding GH-2273: Propagate login to Dawn onboarding Feb 16, 2021
@leuryr leuryr requested a review from ghostery/extension as a code owner Mar 5, 2021
@leuryr leuryr changed the title GH-2273: Propagate login to Dawn onboarding GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX Mar 5, 2021
Copy link
Member

@wlycdgr wlycdgr left a comment

One more thing aside from the comments above - I noticed the toast works when you sign out after signing into an existing account, but does not pop when you sign out after creating a new account. Let's make sure it pops in both scenarios.

@wlycdgr wlycdgr changed the title GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX (CHANGES SUGGESTED) GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX Mar 9, 2021
@wlycdgr wlycdgr changed the title (CHANGES SUGGESTED) GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX Mar 10, 2021
leuryr and others added 2 commits Mar 11, 2021
@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Mar 15, 2021

One more thing aside from the comments above - I noticed the toast works when you sign out after signing into an existing account, but does not pop when you sign out after creating a new account. Let's make sure it pops in both scenarios.

Looks like this is still happening - could you take a look? Aside from not seeing the toast after creating a new account and then signing out, I'm actually also not seeing it after signing out if I signed in in the panel. I AM seeing it if I sign out after signing into an existing account in the onboarding.

Other changes look good, thank you!

Copy link
Member

@wlycdgr wlycdgr left a comment

Smoked it & LGTM

@christophertino christophertino merged commit 358c547 into develop Mar 16, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the GH-2273/onb_sign_in branch Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants