Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX #689
GH-2273, GH-2285, GH-2286: Optimizations to onboarding login & logout UX #689
Changes from 1 commit
2c75a318373096de3829783c79020865aac16410ea362ce9bd2462adFile filter
Jump to
Fix login not propagating to Dawn onboarding
wlycdgrMar 9, 2021
•
edited
Member
I think this satisfies the mild requirements of the use case fine. I mean, we could wait for
actions.getUser()to resolve, but if that fails, we have to let the user through anyway, and either way we don't have any designs or copy for communicating an error to the user in this very unlikely but not particularly terrible scenario.My only suggestion is, I think we can afford to raise the timeout to a second, given the flow of accessing this page.
leuryrMar 11, 2021
Author
Contributor
Yea, I agree eventually having some UI/UX feedback to the user for this would be ideal on the off chance that it happens. I've raised the timeout delay for now though👍