Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rewards pings integration #69

Merged
merged 4 commits into from May 21, 2018
Merged

Feature/rewards pings integration #69

merged 4 commits into from May 21, 2018

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented May 21, 2018 •
edited

GH-1044: Add pings for rewards
Other bug fixes:

  • "OK, Got it." text didn't close the reward. It does now.
  • The "X" in the notification didn't close the reward. It does now.

@jsignanini Pleas approve this PR with only 10 files changed
trickpattyFH20 and others added 3 commits May 18, 2018
@trickpattyFH20 @IAmThePan
persist in localstorage with prefs
3f80180
@christophertino @IAmThePan
update Metrics with new rewards pings and params
c3f681b
@IAmThePan
Add pings for rewards
Loading status checks…
663fbae
@IAmThePan IAmThePan requested review from jsignanini, zarembsky and ghostery/ghostery as code owners May 21, 2018
@jsignanini
Merge branch 'develop' into feature/rewardsPings-integration
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6188812
@jsignanini
jsignanini approved these changes May 21, 2018
View changes
@zarembsky
zarembsky approved these changes May 21, 2018
View changes
Copy link
Contributor

@zarembsky zarembsky left a comment

No comment
@jsignanini jsignanini merged commit 2781d15 into ghostery:develop May 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IAmThePan IAmThePan deleted the IAmThePan:feature/rewardsPings-integration branch May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@IAmThePan @jsignanini @zarembsky @trickpattyFH20 @christophertino